Prospector #42
Prospector #42
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 870 875 +5
Branches 184 184
=====================================
+ Hits 870 875 +5
Continue to review full report at Codecov.
|
wsproto/connection.py
Outdated
| @@ -393,6 +393,34 @@ def _process_connection_request(self, event): | |||
|
|
|||
| return ConnectionRequested(proposed_subprotocols, event) | |||
|
|
|||
| def extension_accept(self, extensions_header): | |||
There was a problem hiding this comment.
Should this be public API?
It doesn't really do anything with the connection, and it is only called via accept.
There was a problem hiding this comment.
Are you suggesting it should be renamed to _extension_accept or that it should go back into the function I pulled it out of?
I'm fine with the former.
There was a problem hiding this comment.
_extension_accept to mark it as private function.
|
General 👍 on the code changes and fixing dormant bugs (I'm looking at you default I'm neutral about prospector vs. flake8. |
Switch from flake8 to prospector for linting.