Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[조별과제#1] 오타 수정 #8

Closed
wants to merge 8 commits into from
Closed

Conversation

dongwook-chan
Copy link

@dongwook-chan dongwook-chan commented Jul 22, 2023

관련 이슈

#7

코드 반영 구조

용어 의미
local 로컬에 clone된 repo
origin 본 repo (원본에서 organization에 포크됨)
upstream 원본 repo
flowchart TB
    subgraph local
    fix-typo-individual-local["fix-typo-individual"]
    end
    fix-typo-individual-local -- "git push" --> fix-typo-individual-origin
    subgraph origin
    fix-typo-individual-origin["fix-typo-individual"]
    fix-typo-individual-origin -- "Pull Request & Merge" --> fix-typo-origin
    fix-typo-origin["fix-typo"]
    end
    fix-typo-origin -- "Pull Request & Merge" --> main-upstream
    subgraph upstream
    main-upstream["main"]
    end
Loading

코드 반영 단계

1. origin을 local로 git clone

git clone https://github.com/23-OSSCA-python-mysql-replication/python-mysql-replication.git
cd python-mysql-replication
git checkout fix-typo-individual

2. local에서 origin으로 git push

git add .
git commit  # commit message는 기존 commit 참고하여 작성
git push fix-typo-individual

3. origin 내부 PR

개인별 local의 fix-typo-individual에서 push한 commit이 PR의 commit 목록에 추가됨
merge하면 모든 commit들이 fix-typo 브랜치에 반영

4. upstream으로의 PR

origin의 fix-typo 브랜치에 반영된 모든 commit이 PR의 commit 목록에 추가됨
merge하면 원본 프로젝트에 모든 commit이 반영 완료

dongwook-chan

This comment was marked as duplicate.

Copy link
Author

@dongwook-chan dongwook-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heehehe 다음부터는 커밋 메시지 영문으로 부탁드릴게요! 이대로 upstream(원본) repo에 올라갈 예정이라서요

@why-arong
Copy link

제가 autopep8을 써서 파일이 저장 과정에서 자동 포매팅된 것을 push를 해버렸습니다..
다시 수정하는 것으로 커밋이 2개되었는데 1개로 합치는 방법 아시나요??
rebase를 사용하면 안될 것 같아서.. 죄송합니다... ㅠㅠㅠ

@dongwook-chan
Copy link
Author

@why-arong rebase 쓰셔도 됩니다!

@heehehe heehehe linked an issue Jul 23, 2023 that may be closed by this pull request
@mirageoasis
Copy link

오타 발견해서 신났는데 여기서 미리하셨군요....
혹시 주석 주소도 바꾸는거도 pr 올려도 되나요? 정해진 주석대로면 처음 설명을 찾는데 헷갈린다고 생각합니다!

@dongwook-chan
Copy link
Author

@mirageoasis 물론입니다 어떤 오타 수정이든 상관 없습니다~

@notion-workspace
Copy link

Untitled

@heehehe heehehe mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

오타 수정 - XAPrepareEvent
8 participants