Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL8-based tests (with percona-8.0) & Upgrade GitHub Actions to Latest Versions (in Preparation for Node 16 EOL) #90

Closed
wants to merge 9 commits into from

Conversation

heehehe
Copy link
Member

@heehehe heehehe commented Sep 19, 2023

Resolve #46 Resolve #89

Overview

Add MySQL-8 based test (with percona-8.0)

Since below two features need to test based on MySQL version 8,
this PR added percona-8.0 docker and test based on MySQL version 8.

Update github actions version

This PR also updates GitHub Actions to use the latest versions of actions/checkout and actions/setup-python
in preparation for the end-of-life of Node 16 in September 2023.
The default runtime of Node 16 will reach its end-of-life on 11 Sep 2023.
To adapt to this change and benefit from the features and optimizations in the newer GitHub Actions versions.

Change

Add MySQL-8 based test (with percona-8.0)

  • Add percona-8.0 docker image with port 3309
  • Add PyMySQLReplicationVersion8TestCase class in pymysqlreplication/tests/base.py
  • Change TestOptionalMetaData's inheritance
    from base.PyMySQLReplicationTestCase to base.PyMySQLReplicationVersion8TestCase
  • Add TestDataTypeVersion8 class in pymysqlreplication/tests/test_data_type.py

Update github actions version

  • From actions/checkout@v2 to actions/checkout@v4
  • From actions/setup-python@v2 to actions/setup-python@v4

Benefits

Add MySQL-8 based test (with percona-8.0)

  • Could test which only works on Mysql verison 8.

Update github actions version

  • Keeps the Actions Up-to-date: Utilizes performance improvements and new features from the latest versions.
  • Future-proofs the Repository: Prepares the codebase for the end of support for Node 16.

References

Update github actions version

@heehehe heehehe force-pushed the feature/docker-percona8 branch from f419dfd to 5e35074 Compare September 19, 2023 14:25
@heehehe heehehe changed the title Add MySQL8-based test Add percona 8.0 docker & MySQL8-based tests Sep 19, 2023
@heehehe heehehe changed the title Add percona 8.0 docker & MySQL8-based tests Add percona 8.0 docker & Add MySQL8-based tests & Update github actions checkout version Sep 19, 2023
@heehehe heehehe changed the title Add percona 8.0 docker & Add MySQL8-based tests & Update github actions checkout version Add MySQL8-based tests with percona 8.0 docker & Update github actions checkout version Sep 19, 2023
@heehehe heehehe changed the title Add MySQL8-based tests with percona 8.0 docker & Update github actions checkout version Add MySQL8-based tests with percona 8.0 docker & Update github actions version Sep 19, 2023
@heehehe heehehe changed the title Add MySQL8-based tests with percona 8.0 docker & Update github actions version Add MySQL8-based tests (with percona-8.0) & Update github actions version Sep 19, 2023
@heehehe heehehe marked this pull request as ready for review September 19, 2023 14:56
@heehehe heehehe changed the title Add MySQL8-based tests (with percona-8.0) & Update github actions version Add MySQL8-based tests (with percona-8.0) & Upgrade GitHub Actions to Latest Versions (in Preparation for Node 16 EOL) Sep 19, 2023
@heehehe heehehe added the 3조 3조 만세 label Sep 19, 2023
Comment on lines +40 to +48
percona-8.0:
<<: *mysql
image: percona:8.0
platform: linux/amd64
ports:
- "3309:3306"
networks:
- default

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment:
  MYSQL_ALLOW_EMPTY_PASSWORD: "yes" 
  환경에 이거 안넣어줘도 잘돌아가는게 신기하네요..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앵커를 썼던데 신기하더라고요!

Copy link
Member

@starcat37 starcat37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버전 관련은 잘 모르기도 해서 팔로업을 못했네요😭 고생하셨어요!🥹🥹

Copy link

@dongwook-chan dongwook-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 3조답게 깔끔하게 수정해주셨네요
제 테스트 살려주신 것도 감사하네요
생명의 은인이십니다 🙏🏻🙏🏻🙏🏻🙏🏻

Copy link

@mikaniz mikaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다!! 경험이 없는 부분이라 도움을 못 드려서 죄송하네요.. 😢
항상 많이 배우고 있습니다!

@heehehe
Copy link
Member Author

heehehe commented Sep 23, 2023

julien-duponchelle#484 반영 완료

@heehehe heehehe closed this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3조 3조 만세
Projects
None yet
6 participants