-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MySQL8-based tests (with percona-8.0) & Upgrade GitHub Actions to Latest Versions (in Preparation for Node 16 EOL) #90
Conversation
f419dfd
to
5e35074
Compare
percona-8.0: | ||
<<: *mysql | ||
image: percona:8.0 | ||
platform: linux/amd64 | ||
ports: | ||
- "3309:3306" | ||
networks: | ||
- default | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
environment:
MYSQL_ALLOW_EMPTY_PASSWORD: "yes"
환경에 이거 안넣어줘도 잘돌아가는게 신기하네요..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앵커를 썼던데 신기하더라고요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버전 관련은 잘 모르기도 해서 팔로업을 못했네요😭 고생하셨어요!🥹🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
역시 3조답게 깔끔하게 수정해주셨네요
제 테스트 살려주신 것도 감사하네요
생명의 은인이십니다 🙏🏻🙏🏻🙏🏻🙏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다!! 경험이 없는 부분이라 도움을 못 드려서 죄송하네요.. 😢
항상 많이 배우고 있습니다!
julien-duponchelle#484 반영 완료 |
Resolve #46 Resolve #89
Overview
Add MySQL-8 based test (with percona-8.0)
Since below two features need to test based on MySQL version 8,
this PR added percona-8.0 docker and test based on MySQL version 8.
Update github actions version
This PR also updates GitHub Actions to use the latest versions of actions/checkout and actions/setup-python
in preparation for the end-of-life of Node 16 in September 2023.
The default runtime of Node 16 will reach its end-of-life on 11 Sep 2023.
To adapt to this change and benefit from the features and optimizations in the newer GitHub Actions versions.
Change
Add MySQL-8 based test (with percona-8.0)
PyMySQLReplicationVersion8TestCase
class inpymysqlreplication/tests/base.py
from
base.PyMySQLReplicationTestCase
tobase.PyMySQLReplicationVersion8TestCase
TestDataTypeVersion8
class inpymysqlreplication/tests/test_data_type.py
Update github actions version
Benefits
Add MySQL-8 based test (with percona-8.0)
Update github actions version
References
Update github actions version