Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PR remote option to --pr-remote #106

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Jun 2, 2017

The new --push/--no-push option conflicts with the old name
of the option for setting the PR remote.

This updates the latter option to the more explicit
--pr-remote.

The new --push/--no-push option conflicts with the old name
of the option for setting the PR remote.

This updates the latter option to the more explicit
`--pr-remote`.
@ncoghlan
Copy link
Contributor Author

ncoghlan commented Jun 2, 2017

Tested by generating python/cpython#1921 and it seems to mostly work.

However, it would be good to remember the PR remote name in the --continue state file: https://github.com/python/core-workflow/issues/107 (I haven't added that yet myself, as I'll need to look into how the command continuation works)

@Mariatta Mariatta merged commit 0242435 into python:master Jun 4, 2017
@Mariatta
Copy link
Member

Mariatta commented Jun 4, 2017

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants