Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C API] Use new PyDict_GetItemRef() C API #108308

Closed
2 tasks done
vstinner opened this issue Aug 22, 2023 · 1 comment
Closed
2 tasks done

[C API] Use new PyDict_GetItemRef() C API #108308

vstinner opened this issue Aug 22, 2023 · 1 comment
Labels
topic-C-API type-bug An unexpected behavior, bug, or error

Comments

@vstinner
Copy link
Member

vstinner commented Aug 22, 2023 •
edited by bedevere-bot
Loading

Bug report

Checklist

  • I am confident this is a bug in CPython, not a bug in a third-party project
  • I have searched the CPython issue tracker,
    and am confident this bug has not been reported before

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

No response

A clear and concise description of the bug:

Calls to PyDict_GetItem() should be replaced with PyDict_GetItemRef().

PyDict_GetItemWithError() may also be replaced with PyDict_GetItemRef().

Linked PRs
@vstinner vstinner added type-bug An unexpected behavior, bug, or error topic-C-API labels Aug 22, 2023
vstinner added a commit to vstinner/cpython that referenced this issue Aug 22, 2023
@vstinner
pythongh-108308: Replace PyDict_GetItem() with PyDict_GetItemRef()
ce6ea31 
Replace PyDict_GetItem() calls with PyDict_GetItemRef() to handle
errors.

pycore_init_builtins() now checks for _PyType_Lookup() failure.
@bedevere-bot bedevere-bot mentioned this issue Aug 22, 2023
Merged
@vstinner vstinner mentioned this issue Aug 22, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Aug 22, 2023
@vstinner
pythongh-108308: Replace PyDict_GetItem() with PyDict_GetItemRef()
53e6f41 
Replace PyDict_GetItem() calls with PyDict_GetItemRef() to handle
errors.

pycore_init_builtins() now checks for _PyType_Lookup() failure.
vstinner added a commit that referenced this issue Aug 23, 2023
@vstinner
gh-108308: Replace PyDict_GetItem() with PyDict_GetItemRef() (#108309)
f5559f3 
Replace PyDict_GetItem() calls with PyDict_GetItemRef()
or PyDict_GetItemWithError() to handle errors.

* Replace PyLong_AS_LONG() with _PyLong_AsInt()
  and check for errors.
* Check for PyDict_Contains() error.
* pycore_init_builtins() checks for _PyType_Lookup() failure.
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: config_dict_get() uses PyDict_GetItemRef()
7c2695d 
Replace PyDict_GetItemWithError() calls with PyDict_GetItemRef() in
config_dict_get() to get a strong reference to the item.
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: config_dict_get() uses PyDict_GetItemRef()
001b0df 
Replace _PyDict_GetItemStringWithError() with PyDict_GetItemRef() in
config_dict_get() to get a strong reference to the item.
@bedevere-bot bedevere-bot mentioned this issue Aug 23, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: Replace _PyDict_GetItemStringWithError()
cc404bb 
Replace _PyDict_GetItemStringWithError() calls with
PyDict_GetItemStringRef().
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: Replace _PyDict_GetItemStringWithError()
cccd30d 
Replace _PyDict_GetItemStringWithError() calls with
PyDict_GetItemStringRef().
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: Replace _PyDict_GetItemStringWithError()
d23cfd3 
Replace _PyDict_GetItemStringWithError() calls with
PyDict_GetItemStringRef() which returns a strong reference to the
item.
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: Replace _PyDict_GetItemStringWithError()
03b456e 
Replace _PyDict_GetItemStringWithError() calls with
PyDict_GetItemStringRef() which returns a strong reference to the
item.
@bedevere-bot bedevere-bot mentioned this issue Aug 23, 2023
Merged
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner @serhiy-storchaka
pythongh-108308: Replace _PyDict_GetItemStringWithError()
a1192ad 
Replace _PyDict_GetItemStringWithError() calls with
PyDict_GetItemStringRef() which returns a strong reference to the
item.

Co-Authored-by: Serhiy Storchaka <[email protected]>
vstinner added a commit that referenced this issue Aug 23, 2023
@vstinner @serhiy-storchaka
gh-108308: Replace _PyDict_GetItemStringWithError() (#108372)
4dc9f48 
Replace _PyDict_GetItemStringWithError() calls with
PyDict_GetItemStringRef() which returns a strong reference to the
item.

Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner added a commit that referenced this issue Aug 23, 2023
@vstinner
gh-108308: config_dict_get() uses PyDict_GetItemRef() (#108371)
ec3527d 
Replace _PyDict_GetItemStringWithError() with PyDict_GetItemRef() in
config_dict_get() to get a strong reference to the item.
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: Use PyDict_GetItemRef() in moduleobject.c
02769b2 
Replace PyDict_GetItemWithError() with PyDict_GetItemRef() which
returns a strong reference.

Cleanup also the function: move variable definition to their first
assignation, rename variable names to use name longer than 1
character.
vstinner added a commit to vstinner/cpython that referenced this issue Aug 23, 2023
@vstinner
pythongh-108308: Use PyDict_GetItemRef() in moduleobject.c
c479ee7 
Replace PyDict_GetItemWithError() with PyDict_GetItemRef() which
returns a strong reference.

Cleanup also the function: move variable definition to their first
assignation, rename variable names to use name longer than 1
character.
@bedevere-bot bedevere-bot mentioned this issue Aug 23, 2023
Merged
vstinner added a commit that referenced this issue Aug 23, 2023
@vstinner
gh-108308: Use PyDict_GetItemRef() in moduleobject.c (#108381)
4890f65 
Replace PyDict_GetItemWithError() with PyDict_GetItemRef() which
returns a strong reference.

Cleanup also the function: move variable definition to their first
assignation, rename variable names to use name longer than 1
character.
vstinner added a commit to vstinner/cpython that referenced this issue Aug 24, 2023
@vstinner
pythongh-108308: Remove _PyDict_GetItemStringWithError() function
aa300f2 
Remove the internal _PyDict_GetItemStringWithError() function. It can
now be replaced with the new public PyDict_ContainsString() and
PyDict_GetItemStringRef() functions.

getargs.c now uses a strong reference for current_arg.
find_keyword() returns a strong reference.
@bedevere-bot bedevere-bot mentioned this issue Aug 24, 2023
Merged
vstinner added a commit that referenced this issue Aug 24, 2023
@vstinner
gh-108308: Remove _PyDict_GetItemStringWithError() function (#108426)
52c6a6e 
Remove the internal _PyDict_GetItemStringWithError() function. It can
now be replaced with the new public PyDict_ContainsString() and
PyDict_GetItemStringRef() functions.

getargs.c now now uses a strong reference for current_arg.
find_keyword() returns a strong reference.
@vstinner
Copy link
Member Author

PyDict_GetItem() and PyDict_GetItemString() are no longer used in Python code base.

I added PyDict_ContainsString() and removed the _PyDict_GetItemStringWithError() function.

I consider that the work is now done here, I close the issue. Thanks to everyone who helped with reviews :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-C-API type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vstinner