Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python dictionary watchers no longer trigger when an object's attributes change #125608

Closed
colesbury opened this issue Oct 16, 2024 · 2 comments
Closed

Python dictionary watchers no longer trigger when an object's attributes change #125608

colesbury opened this issue Oct 16, 2024 · 2 comments
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Oct 16, 2024 •
edited by bedevere-app bot
Loading

Bug report

Here's an example function using test_capi/test_watchers.py that passes in 3.12, but fails in 3.13 and 3.14:

    def test_watch_obj_dict(self):
        o = MyClass()
        with self.watcher() as wid:
            self.watch(wid, o.__dict__)
            o.foo = "bar"
            self.assert_events(["new:foo:bar"])  # fails in 3.13+

The dictionary watcher doesn't fire in 3.13+ even though the o.__dict__ changes when o.foo is set to "bar". The problem is specific to inline values -- our code paths for inline values do not trigger dictionary watcher events. If the object does not use inline values, then the watcher events fire as expected.

This is a problem for PyTorch Dyanmo because it uses dictionary watchers for compiler guards.

cc @williamwen42 @markshannon

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Oct 16, 2024
@williamwen42
Copy link
Contributor

cc @anijain2305

colesbury added a commit to colesbury/cpython that referenced this issue Oct 16, 2024
@colesbury
pythongh-125608: Trigger dictionary watchers when inline values cahnge
Loading
Loading status checks…
3c3f150 
Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
@bedevere-app bedevere-app bot mentioned this issue Oct 16, 2024
Merged
colesbury added a commit to colesbury/cpython that referenced this issue Oct 16, 2024
@colesbury
pythongh-125608: Trigger dictionary watchers when inline values change
Loading
Loading status checks…
28871ed 
Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
@williamwen42 williamwen42 mentioned this issue Oct 17, 2024
Closed
colesbury added a commit that referenced this issue Oct 21, 2024
@colesbury
gh-125608: Trigger dictionary watchers when inline values change (#12…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
5989eb7 
…5611)

Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
22a6d9e 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
Loading
Loading status checks…
7a7c74f 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
679f84b 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
Loading
Loading status checks…
797aa18 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
29e9af1 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
Loading
Loading status checks…
96c3a90 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
3ebb7e4 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 22, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
Loading
Loading status checks…
293d162 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 25, 2024
@colesbury @miss-islington
pythongh-125608: Trigger dictionary watchers when inline values change (
Loading
Loading status checks…
9793b96 
pythonGH-125611)

Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
(cherry picked from commit 5989eb7)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Oct 25, 2024
Merged
colesbury added a commit that referenced this issue Oct 25, 2024
@miss-islington @colesbury
[3.13] gh-125608: Trigger dictionary watchers when inline values chan…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
7b46ae9 
…ge (GH-125611) (GH-125982)

Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
(cherry picked from commit 5989eb7)

Co-authored-by: Sam Gross <[email protected]>
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 25, 2024
@williamwen42
Update base for Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
b8c7d36 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
williamwen42 added a commit to pytorch/pytorch that referenced this issue Oct 25, 2024
@williamwen42
Update on "[dynamo] handle 3.13.0 __dict__ watcher bug"
Loading
Loading status checks…
f1f1b4d 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames rec

[ghstack-poisoned]
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this issue Oct 28, 2024
@williamwen42 @pytorchmergebot
[dynamo] handle 3.13.0 __dict__ watcher bug (#138284)
Loading
Loading status checks…
904816d 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

Pull Request resolved: #138284
Approved by: https://github.com/jansel
ghstack dependencies: #138030
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this issue Oct 29, 2024
@williamwen42 @rahulsingh-intel
[dynamo] handle 3.13.0 __dict__ watcher bug (pytorch#138284)
32ddf67 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

Pull Request resolved: pytorch#138284
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#138030
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this issue Nov 5, 2024
@williamwen42 @rahulsingh-intel
[dynamo] handle 3.13.0 __dict__ watcher bug (pytorch#138284)
dc1c563 
python/cpython#116115 introduced a bug (python/cpython#125608) where changing the attributes of an object may not fire the dict watchers registered to the object's `__dict__`. It has been fixed by python/cpython#125611 but will only be in 3.13.1+.

This PR disables the dict watcher guard shortcut for `__dict__`s on 3.13.0 and warns the user to try using 3.13.1+ instead. We also added a simple test to check for this functionality in the future.

Pull Request resolved: pytorch#138284
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#138030
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@colesbury @ebonnal
pythongh-125608: Trigger dictionary watchers when inline values change (
a60818a 
python#125611)

Dictionary watchers on an object's attributes dictionary
(`object.__dict__`) were not triggered when the managed dictionary used
the object's inline values.
@ZeroIntensity
Copy link
Member

Doing some triaging, this looks like it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colesbury @williamwen42 @ZeroIntensity