Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-80527: Change support.requires_legacy_unicode_capi() (GH-108438) #108446

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 24, 2023

The decorator now requires to be called with parenthesis:

@support.requires_legacy_unicode_capi()

instead of:

@support.requires_legacy_unicode_capi

The implementation now only imports _testcapi when the decorator is
called, so "import test.support" no longer imports the _testcapi
extension.
(cherry picked from commit 995f4c4)

Co-authored-by: Victor Stinner [email protected]

…GH-108438)

The decorator now requires to be called with parenthesis:

    @support.requires_legacy_unicode_capi()

instead of:

    @support.requires_legacy_unicode_capi

The implementation now only imports _testcapi when the decorator is
called, so "import test.support" no longer imports the _testcapi
extension.
(cherry picked from commit 995f4c4)

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot

@rhettinger rhettinger removed their request for review August 25, 2023 04:48
@Yhg1s Yhg1s merged commit 0eb6d87 into python:3.12 Aug 25, 2023
@miss-islington miss-islington deleted the backport-995f4c4-3.12 branch August 25, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants