GH-117750: When clearing object's dict, clear inline values but leave dict attached #117808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
markshannon
commented
Apr 12, 2024
•
markshannon
commented
- Issue: _PyObject_StoreInstanceAttribute assertion fails in setattr after __dict__.clear() #117750
markshannon
changed the title
|
This is not the most obvious fix. That would be to invalidate the object's values when clearing the dict. However, invalidation would be much less efficient for subsequent attribute access, if those attributes can be shared. |
iritkatriel
approved these changes
Apr 15, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
… leave dict attached (pythonGH-117808)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.