bpo-32592: Set Windows 8 as the minimum required version for API support #15951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to require a change to the buildbot config to turn off the 3.x builder on the Windows 7 bot(s). I'd rather wait on this until that change is in than to have to make the change to fix the breakage. |
|
It shouldn't, as the minimum API isn't actually enforced anywhere except at compile time, and all the Win10 SDKs have the Win8 APIs available. |
|
I've started a buildbot-custom build to check that. |
|
Don't merge this before #15949 or it'll break the other one. (That PR is being backported, and then I'll have to rebase this one...) |
|
The Win7 SP1 buildbot is happy, so I'll merge this after #15949. |
zware
approved these changes
Sep 11, 2019
|
Thanks! |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Sep 12, 2019
kuba2k2
pushed a commit
to kuba2k2/cpython
that referenced
this pull request
Nov 13, 2021
…API support (pythonGH-15951)" This reverts commit 0b72ccf.
kuba2k2
pushed a commit
to kuba2k2/cpython
that referenced
this pull request
Nov 13, 2021
…API support (pythonGH-15951)" This reverts commit 0b72ccf.
ChronoMonochrome
added a commit
to ChronoMonochrome/cpython
that referenced
this pull request
Nov 16, 2021
…API support (pythonGH-15951)" This reverts commit 0b72ccf.
kuba2k2
pushed a commit
to kuba2k2/cpython
that referenced
this pull request
Dec 5, 2024
…API support (pythonGH-15951)" This reverts commit 0b72ccf.
kuba2k2
pushed a commit
to kuba2k2/cpython
that referenced
this pull request
Dec 5, 2024
…API support (pythonGH-15951)" This reverts commit 0b72ccf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32592