-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43352: Add a Barrier object in asyncio lib #24903
Conversation
Add a Barrier object to asyncio synchronized primitives
Change after run make patchcheck
run make patchcheck
Add comment when testing self._state Change if to while instruction in _block method
Refactoring all test names of BarrierTests to be more readable Add a method cancel_coros Refactoring and simplifyiing some tests Correction of RGX_REPR
after run python.bat Tools\scripts\patchcheck.py
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Please post a clean PR. The current version touches 23 files, most of which are new |
29b38e3
to
04d4f69
Compare
PR was cleaned, stayed only 2 files now |
Please update the documentation. |
@rhettinger I am a rookie on cpython. |
Add Barrier object as a clone of threading.Barrier
Sorry, bad merge with master |
…ythonGH-24903) Minor correction in example
Merged. Thanks for your patience, @YvesDup |
A very big thank you to @asvetlov and @1st1 for your support and all the work done together on this PR, my first one !! Thanks to @eamanu for your review, and a special thanks to @JulienPalard for his help especially on the good practices on PS: @asvetlov should I do something else, or just close this PR ? |
Everything is done. PR is merged, https://bugs.python.org/issue43352 is closed. |
@asvetlov Please can tell me how to add a paragraph in whatnew 3.11#asyncio about this new feature ? |
@YvesDup Just submit a PR for |
You can reference the same issue (now migrated to #87518). |
@gvanrossum Job in progress. Thank you |
bpo-43352: Add a Barrier object in asyncio lib
Copy design of object Barrier from threading, same features
Modified files are:
file lib/asyncio/locks.py
file lib/test/test_asyncio/test_locks.py
I am not familiar with git, so all files with .rst.bak extension are not in the scope of this PR
Just see https://bugs.python.org/issue37945, so the following paragraph can be deleted
"""
All tests (Win10 Python x64) are done and succesfull except one: python -m test -v test_locale
I am surprised about this error because, asyncio and locale are not linked, or are they ?
Please, how to proceed about this failure ? Open a new issue on bpo ?
a log file is available.
Thank for help
"""
https://bugs.python.org/issue43352