Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30593: Document that sqlite3.Cursor.executescript disregards isolation_level #26220

Merged
merged 1 commit into from
May 19, 2021
Merged

bpo-30593: Document that sqlite3.Cursor.executescript disregards isolation_level #26220

merged 1 commit into from
May 19, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 18, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels May 18, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 18, 2021 •
edited
Loading

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).

@pablogsal
Copy link
Member

@pablogsal I'm adding skip news to this. Can be backported to 3.10 and 3.9 (3.8 doesn't even get doc updates anymore, right?).

Yep, docs changes can almost always be backported!

@erlend-aasland
Copy link
Contributor Author

Yep, docs changes can almost always be backported!

All right :) Thanks.

@erlend-aasland
Copy link
Contributor Author

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?

@pablogsal
Copy link
Member

But I note that Berker chose only to apply backport labels for 3.10 and 3.9 to GH-26027. Maybe do likewise here?

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...

@berkerpeksag berkerpeksag merged commit 9014437 into python:main May 19, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
@miss-islington
bpo-30593: Doc'ed that executescript() disregards isolation level (py…
b9461c1 
…thonGH-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot
Copy link

GH-26230 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 19, 2021
@erlend-aasland erlend-aasland deleted the bpo-30593 branch May 19, 2021 07:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
@miss-islington
bpo-30593: Doc'ed that executescript() disregards isolation level (py…
3605012 
…thonGH-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 19, 2021
@bedevere-bot
Copy link

GH-26231 is a backport of this pull request to the 3.9 branch.

@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing, Berker & Pablo!

@berkerpeksag
Copy link
Member

I don't see personally any problem of improving the docs of all versions even if they are in sec fixes only, bit maybe I am missing some context...

It's because historically online documentation of security-fix-only branches weren't updated daily.

berkerpeksag pushed a commit that referenced this pull request May 19, 2021
@miss-islington
bpo-30593: Doc'ed that executescript() disregards isolation level (GH…
76ed53c 
…-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
berkerpeksag pushed a commit that referenced this pull request May 19, 2021
@miss-islington
bpo-30593: Doc'ed that executescript() disregards isolation level (GH…
1f483c0 
…-26220)

(cherry picked from commit 9014437)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@pablogsal pablogsal pablogsal approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erlend-aasland @pablogsal @miss-islington @bedevere-bot @berkerpeksag @the-knights-who-say-ni