-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in the Include directory #28745
Conversation
Thanks! FWIW some people find fixing up typos to be contentious as it can be seen as churn. Feel free to loop me in as a reviewer on any CPython PRs for comment/docs typo fixes. They do improve our codebase overall and when done as this one is, across a bunch of files at once systematically, reduce the plethora of future random PRs from people over time fixing just one thing at a time. |
@cclauss, just like elsewhere, we'll appreciate a manual [3.10] and [3.9] version of this PR to help us avoid future backport conflicts. |
Sorry, @cclauss and @gpshead, I could not cleanly backport this to |
Sorry @cclauss and @gpshead, I had trouble checking out the |
(apparently this one does need to be done manually, had to check :) |
If a sweeping change worked across branches, I'd be super surprised :D |
@gpshead Thanks for your guidance. There are four more PRs to review if you have time/interest. https://github.com/python/cpython/pulls/cclauss @ambv I will go at the backports in my morning. |
(cherry picked from commit 8e8f752)
GH-28788 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 8e8f752)
GH-28789 is a backport of this pull request to the 3.10 branch. |
Like #28744 but for the Include directory.
[skip issue] Opening a related issue is pending python/psf-infra-meta#130