Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the Include directory #28745

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 5, 2021

Like #28744 but for the Include directory.

[skip issue] Opening a related issue is pending python/psf-infra-meta#130

@gpshead gpshead added skip issue skip news docs Documentation in the Doc dir labels Oct 6, 2021
@gpshead gpshead merged commit 8e8f752 into python:main Oct 6, 2021
@gpshead
Copy link
Member

gpshead commented Oct 6, 2021

Thanks! FWIW some people find fixing up typos to be contentious as it can be seen as churn. Feel free to loop me in as a reviewer on any CPython PRs for comment/docs typo fixes. They do improve our codebase overall and when done as this one is, across a bunch of files at once systematically, reduce the plethora of future random PRs from people over time fixing just one thing at a time.

@ambv
Copy link
Contributor

ambv commented Oct 6, 2021

@cclauss, just like elsewhere, we'll appreciate a manual [3.10] and [3.9] version of this PR to help us avoid future backport conflicts.

@gpshead gpshead added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Oct 6, 2021
@miss-islington
Copy link
Contributor

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @cclauss for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @cclauss and @gpshead, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8e8f7522171ef82f2f5049940f815e00e38c6f42 3.9

@miss-islington
Copy link
Contributor

Sorry @cclauss and @gpshead, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e8f7522171ef82f2f5049940f815e00e38c6f42 3.10

@gpshead
Copy link
Member

gpshead commented Oct 6, 2021

(apparently this one does need to be done manually, had to check :)

@ambv
Copy link
Contributor

ambv commented Oct 6, 2021

If a sweeping change worked across branches, I'd be super surprised :D

@cclauss cclauss deleted the codespell-Include branch October 6, 2021 20:30
@cclauss
Copy link
Contributor Author

cclauss commented Oct 6, 2021

@gpshead Thanks for your guidance. There are four more PRs to review if you have time/interest. https://github.com/python/cpython/pulls/cclauss

@ambv I will go at the backports in my morning.

@bedevere-bot
Copy link

GH-28788 is a backport of this pull request to the 3.9 branch.

cclauss added a commit to cclauss/cpython that referenced this pull request Oct 7, 2021
@bedevere-bot
Copy link

GH-28789 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 7, 2021
miss-islington pushed a commit that referenced this pull request Oct 7, 2021
miss-islington pushed a commit that referenced this pull request Oct 7, 2021
@cclauss
Copy link
Contributor Author

cclauss commented Oct 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants