Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getpath.c easier to follow. #28909

Closed
wants to merge 9 commits into from
Closed

Make getpath.c easier to follow. #28909

wants to merge 9 commits into from

Conversation

ericsnowcurrently
Copy link
Member

This change helps make getpath.c more understandable and easier to modify. It involves 3 changes:

  • rename some variables/functions
  • calculate stdlib_dir separately
  • track information about various filenames, especially stdlib_dir

I've avoided changing any behavior or exposing internal data that wasn't already. I'm saving that for a follow-up PR.

@ericsnowcurrently ericsnowcurrently removed the request for review from vstinner October 14, 2021 18:24
@ericsnowcurrently
Copy link
Member Author

Given @zooba is working on #29041, I'm closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba Awaiting requested review from zooba

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot