bpo-41498: Fix build on platforms without sigset_t (GH-29770) #29770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
needs backport to 3.9
Python now compiles on platforms without ``sigset_t``. Several functions in :mod:`signal` are not available when ``sigset_t`` is missing. Based on patch by Roman Yurchak for pyodide. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo-41498-sigset_t
branch
from
86474f4 to
691eef3
Compare
pablogsal
approved these changes
Nov 25, 2021
|
It would be good to have a buildbot validating these but is simple enough to go ahead |
We'll get some smoke tests for the problem when we have wasm builds. |
tiran
changed the title
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry, @tiran, I could not cleanly backport this to |
|
GH-29773 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 25, 2021
(cherry picked from commit dc19e86) Co-authored-by: Christian Heimes <[email protected]>
tiran
added a commit
to tiran/cpython
that referenced
this pull request
Nov 25, 2021
). (cherry picked from commit dc19e86) Co-authored-by: Christian Heimes <[email protected]>
|
GH-29774 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 25, 2021
…H-29773) (cherry picked from commit dc19e86) Co-authored-by: Christian Heimes <[email protected]> Automerge-Triggered-By: GH:tiran
tiran
added a commit
that referenced
this pull request
Nov 25, 2021
…H-29774) Co-authored-by: Christian Heimes <[email protected]>
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python now compiles on platforms without
sigset_t. Several functionsin :mod:
signalare not available whensigset_tis missing.Based on patch by Roman Yurchak for pyodide.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue41498