-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sphinx-lint after #31097 and b878b3a #31248
Conversation
Oops I should have rebased right before merging this one, I'm looking at it! |
Thanks @sobolevn for the fast PR :) |
@sobolevn: Status check is done, and it's a success ✅ . |
I backported the tarfile change to 3.9 and 3.10, do these branches also need a fix? https://bugs.python.org/issue45863 |
I didn't notice the failure on the PR #29693 Is it because the branch is old (Nov 2021) and was not rebased before being merged? Maybe the strict CI tests were added later? |
Yes, looks like this is the case. |
I did not backported sphinx-lint to old branch and I don't want to, rstlint does an OK job on those branche, sphinx-lint is very new, main is enough for me. |
main
branch is failing, see https://dev.azure.com/python/cpython/_build/results?buildId=96616&view=logs&j=4db1505a-29e5-5cc0-240b-53a8a2681f75&t=a975920c-8356-5388-147c-613d5fab0171Logs:
This PR fixes these two problems, so
main
is green again.Related PR: #31097
CC @JulienPalard
Automerge-Triggered-By: GH:JulienPalard