[3.9] bpo-46615: Don't crash when set operations mutate the sets (GH-31120) #31312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweeneyde
commented
Feb 13, 2022
| @@ -1515,17 +1529,21 @@ set_difference(PySetObject *so, PyObject *other) | |||
| while (set_next(so, &pos, &entry)) { | |||
| key = entry->key; | |||
| hash = entry->hash; | |||
| Py_INCREF(key); | |||
| rv = _PyDict_Contains(other, key, hash); | |||
There was a problem hiding this comment.
Note: cherry-picker only struggled because this is _PyDict_Contains_KnownHash() in main.
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…31120) (pythonGH-31312) Ensure strong references are acquired whenever using `set_next()`. Added randomized test cases for `__eq__` methods that sometimes mutate sets when called. (cherry picked from commit 4a66615)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure strong references are acquired whenever using
set_next(). Added randomized test cases for__eq__methods that sometimes mutate sets when called.(cherry picked from commit 4a66615)
https://bugs.python.org/issue46615