Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40280: Block more non-working syscalls in Emscripten (GH-31757) #31757

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 8, 2022

  • getgroups always fails.
  • geteuid and getegid always return 0 (root), which confuse tarfile and
    tests.
  • hardlinks (link, linkat) always fails.
  • non-encodable file names are not supported by NODERAWFS layer.
  • mark more tests with dependency on subprocess and multiprocessing.
    Mocking does not work if the module fails to import.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue40280

- getgroups always fails.
- geteuid and getegid always return 0 (root), which confuse tarfile and
  tests.
- hardlinks (link, linkat) always fails.
- non-encodable file names are not supported by NODERAWFS layer.
- mark more tests with dependency on subprocess and multiprocessing.
  Mocking does not work if the module fails to import.

Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran added the skip news label Mar 8, 2022
@tiran tiran changed the title bpo-40280: Block more non-working syscalls in Emscripten bpo-40280: Block more non-working syscalls in Emscripten (GH-31757) Mar 8, 2022
@tiran tiran merged commit 5081e78 into python:main Mar 8, 2022
@tiran tiran deleted the bpo-40280-even-more-syscalls branch March 8, 2022 11:17
@brettcannon brettcannon self-requested a review March 8, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants