-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-91291: Accept attributes as keyword arguments in decimal.localcontext #32242
Conversation
Thank you for the review, I'll be able to make the changes later today |
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from one nit which I'll apply myself. Then I'll also run this through the buildbots in case there's a refleak.
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit df3ab57 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
It seems like this change caused a regression: #91821 |
Oh, interesting. I'll try and work out where the issue is. |
This allows attributes to be set like this
instead of like this
#91291
https://bugs.python.org/issue47135