bpo-33188: Allow dynamic creation of generic dataclasses #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6320 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 31, 2018
(cherry picked from commit 5a7092d) Co-authored-by: Ivan Levkivskyi <[email protected]>
|
Looks fantastic. |
ilevkivskyi
added a commit
that referenced
this pull request
Apr 1, 2018
(cherry picked from commit 5a7092d) Co-authored-by: Ivan Levkivskyi <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per PEP 560 the only way to dynamically create generic classes is by calling
types.new_class. It turns out that some users are interested in dynamic creation of generic dataclasses. I propose to allow this, by usingtypes.new_class()instead oftype()inmake_dataclass(). I propose to don't change the signature of the latter because of this rare use case (but it is not a strong opinion).https://bugs.python.org/issue33188