Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91810: Expand ElementTree.write() tests to use non-ASCII data #91989

Merged
merged 1 commit into from
Apr 27, 2022
Merged

gh-91810: Expand ElementTree.write() tests to use non-ASCII data #91989

merged 1 commit into from
Apr 27, 2022
+80 −17

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Apr 27, 2022
@serhiy-storchaka serhiy-storchaka merged commit f60b4c3 into python:main Apr 27, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_xml_etree branch April 27, 2022 16:16
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f60b4c3d74f241775f80affe60dcba6448634fe3 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Apr 27, 2022
@bedevere-bot
Copy link

GH-91991 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2022
@serhiy-storchaka @miss-islington
pythongh-91810: Expand ElementTree.write() tests to use non-ASCII data (

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
74fec20 
pythonGH-91989)

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 27, 2022
@serhiy-storchaka
[3.9] pythongh-91810: Expand ElementTree.write() tests to use non-ASC…
ece063d 
…II data (pythonGH-91989).

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-91994 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 27, 2022
miss-islington added a commit that referenced this pull request Apr 27, 2022
@miss-islington @serhiy-storchaka
gh-91810: Expand ElementTree.write() tests to use non-ASCII data (GH-…
777d478 
…91989)

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Apr 27, 2022
@serhiy-storchaka
[3.9] gh-91810: Expand ElementTree.write() tests to use non-ASCII data (
993bb16 
GH-91989). (GH-91994)

(cherry picked from commit f60b4c3)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@serhiy-storchaka @hello-adam
[3.9] pythongh-91810: Expand ElementTree.write() tests to use non-ASC…
8d2b4c0 
…II data (pythonGH-91989). (pythonGH-91994)

(cherry picked from commit f60b4c3)
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot