gh-91491: Complete Whats New in 3.11 for typing #92708
Conversation
| * Loosen runtime requirements for type annotations by removing the callable | ||
| check in the private ``typing._type_check`` function. (Contributed by | ||
| Gregory Beauregard in :gh:`90802`.) |
There was a problem hiding this comment.
Should we really include this? It's a private undocumented function (though David's recent bug report suggested to me otherwise).
There was a problem hiding this comment.
Given that it's already spawned a bug report, it's likely that other users will run into this change, so I think it's important to include.
There was a problem hiding this comment.
Agreed then. Could you please add a notice strongly discouraging users from using it too? We might as well try to dissuade users though it might be in vain :).
This function is for internal use only and is **unstable** and may change across versions. Please do not use this function. Instead, we recommend implementing this with your own code.There was a problem hiding this comment.
That feels like a bit much for the What's New document. We should say what changed, but I don't think we need more than that.
Co-authored-by: Shantanu <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry @JelleZijlstra, I had trouble checking out the |
JelleZijlstra
added
needs backport to 3.11
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Fixes pythonGH-91491 Co-authored-by: Shantanu <[email protected]> Co-authored-by: Alex Waygood <[email protected]> (cherry picked from commit 6b51773) Co-authored-by: Jelle Zijlstra <[email protected]>
|
GH-92958 is a backport of this pull request to the 3.11 branch. |
Fixes GH-91491 Co-authored-by: Shantanu <[email protected]> Co-authored-by: Alex Waygood <[email protected]> (cherry picked from commit 6b51773) Co-authored-by: Jelle Zijlstra <[email protected]>
Fixes #91491