-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) #93651
[3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) #93651
Conversation
…ing spawn (pythonGH-30617) Co-authored-by: XD Trol <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> (cherry picked from commit 30610d2) Co-authored-by: Leo Trol <[email protected]>
@vstinner Do you know why we get a CLA signing failure here that did not exist on the original PR? |
vs
One email has a dot, not the other. I don't know what's going on. @ambv: Do you have an idea why the email address is different and the CLA check fails? |
Status check is done, and it's a success ✅ . |
CLA fixed. It seems that Github auto-generated commits ignore dots in email addresses, but the CLA bot does not. |
Status check is done, and it's a success ✅ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, backport from main branch.
The CLA bot should probably also ignore dots in emails. |
@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local |
test_signal has been running for 28 min on the remaining buildbot... Is it ok to merge nevertheless? @vstinner |
Status check is done, and it's a success ✅ . |
@pitrou In my experience the buildbots get added in waves so the fact that there is "just one left" isn't enough to merge early. In this case miss-islington already merged so hopefully we went through all of them. |
Yes, the email address in ~/.gitconfig does differ from GitHub account email address. |
Co-authored-by: XD Trol [email protected]
Co-authored-by: Antoine Pitrou [email protected]
(cherry picked from commit 30610d2)
Co-authored-by: Leo Trol [email protected]