Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) #93651

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

miss-islington
Copy link
Contributor

Co-authored-by: XD Trol [email protected]
Co-authored-by: Antoine Pitrou [email protected]
(cherry picked from commit 30610d2)

Co-authored-by: Leo Trol [email protected]

…ing spawn (pythonGH-30617)

Co-authored-by: XD Trol <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
(cherry picked from commit 30610d2)

Co-authored-by: Leo Trol <[email protected]>
@miss-islington miss-islington requested a review from 1st1 as a code owner June 9, 2022 16:55
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jun 9, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@miss-islington
Copy link
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

@pitrou
Copy link
Member

pitrou commented Jun 9, 2022

@vstinner Do you know why we get a CLA signing failure here that did not exist on the original PR?

@vstinner
Copy link
Member

vstinner commented Jun 9, 2022

Co-authored-by: XD Trol [email protected]

vs

The following commit authors need to sign the Contributor License Agreement: [email protected]

One email has a dot, not the other. I don't know what's going on.

@ambv: Do you have an idea why the email address is different and the CLA check fails?

@miss-islington
Copy link
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@jxdabc
Copy link
Contributor

jxdabc commented Jun 10, 2022

Co-authored-by: XD Trol [email protected]

vs

The following commit authors need to sign the Contributor License Agreement: [email protected]

One email has a dot, not the other. I don't know what's going on.

@ambv: Do you have an idea why the email address is different and the CLA check fails?

CLA fixed. It seems that Github auto-generated commits ignore dots in email addresses, but the CLA bot does not.

cc @vstinner @pitrou

@pitrou pitrou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 10, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pitrou for commit 54e06c1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 10, 2022
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, backport from main branch.

@ambv
Copy link
Contributor

ambv commented Jun 10, 2022

The CLA bot should probably also ignore dots in emails.

@ambv
Copy link
Contributor

ambv commented Jun 10, 2022

@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local ~/.gitconfig email address and the GitHub account email address?

@miss-islington
Copy link
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a pending ❌ .

@pitrou
Copy link
Member

pitrou commented Jun 10, 2022

test_signal has been running for 28 min on the remaining buildbot... Is it ok to merge nevertheless? @vstinner

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit aee7d3d into python:3.11 Jun 10, 2022
@miss-islington miss-islington deleted the backport-30610d2-3.11 branch June 10, 2022 15:05
@ambv
Copy link
Contributor

ambv commented Jun 10, 2022

@pitrou In my experience the buildbots get added in waves so the fact that there is "just one left" isn't enough to merge early. In this case miss-islington already merged so hopefully we went through all of them.

@jxdabc
Copy link
Contributor

jxdabc commented Jun 14, 2022

@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local ~/.gitconfig email address and the GitHub account email address?

Yes, the email address in ~/.gitconfig does differ from GitHub account email address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants