Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] GH-93516: Drop broken assert, fixes GH-93769 #94411

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[3.11] GH-93516: Drop broken assert, fixes GH-93769 #94411

merged 1 commit into from
Jun 29, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 29, 2022 •
edited by bedevere-bot
Loading

The assert is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be _PyOpcode_Deopt[_Py_OPCODE(...)] instead of
_PyOpcode_Deopt[...].

@tiran
[3.11] pythonGH-93516: Drop broken assert, fixes pythonGH-93769
8fd8bc4 
The ``assert`` is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be ``_PyOpcode_Deopt[_Py_OPCODE(...)]`` instead of
``_PyOpcode_Deopt[...]``.
@tiran tiran requested a review from markshannon as a code owner June 29, 2022 10:46
@tiran tiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jun 29, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 8fd8bc4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@tiran tiran mentioned this pull request Jun 29, 2022
Closed
@markshannon
Copy link
Member

Thanks

@markshannon markshannon merged commit 9140c41 into python:3.11 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiran @bedevere-bot @markshannon