-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-94598: Remove deprecated ssl modules features #94599
base: main
Are you sure you want to change the base?
Conversation
tiran
commented
Jul 6, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: [ssl] Remove deprecated protocols, OP_NO_TLS/SSL, and support for TLS < 1.2 #94598
|
ae51bdc
to
cfe4777
Compare
Can you make these attributes warn on access in 3.11? using the approach here Lines 28 to 38 in 6dadf6c
Currently they only warn at use, and it would make testing this change much easier if they warn on access |
Enum's convert helper gets in the way. It adds the variables to global name space unconditionally. |
Could you |
That's ugly. |
It's ugly but it would give users a heads-up this is going to be removed. |
The ssl module has been warning about deprecated features since 3.10:
Functions and methods don't warn on attribute access either. They typically warn when they are called (used). |
Compromise: 3.11 is at the end of its beta phase. I don't want to add ugly code to it. Instead I'm going to add warnings for the deprecated module constants to 3.12 and remove them in 3.13. They won't work in 3.12, though. Attribute access won't raise an AttributeError.
|
@@ -427,17 +477,6 @@ class SSLContext(_SSLContext): | |||
sslsocket_class = None # SSLSocket is assigned later. | |||
sslobject_class = None # SSLObject is assigned later. | |||
|
|||
def __new__(cls, protocol=None, *args, **kwargs): |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Is there any chance to get it into 3.12b1? |
Feel free to pick it up and prepare it for the next 3.13 alpha. |