GH-92678: Document that you shouldn't be doing your own dictionary offset calculations. #95598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-bot
added
docs
encukou
previously approved these changes
Aug 4, 2022
|
Actually, |
|
Added in faster-cpython#13. |
|
See faster-cpython#14 for that alternative. |
It shouldn't. |
encukou
approved these changes
Aug 5, 2022
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Stanley <[email protected]>
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-95821 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 9, 2022
…ary offset calculations. (pythonGH-95598) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Stanley <[email protected]> (cherry picked from commit 8d37c62) Co-authored-by: Mark Shannon <[email protected]>
markshannon
added a commit
that referenced
this pull request
Aug 9, 2022
…fset calculations. (GH-95598) (GH-95821) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Stanley <[email protected]> Co-authored-by: Mark Shannon <[email protected]>
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
…ary offset calculations. (pythonGH-95598) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Stanley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like no one was doing their own address calculation anyway, but the docs needed updating.