Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-96046: Initialize ht_cached_keys in PyType_Ready() (GH-96047) #96164

Merged
merged 1 commit into from
Aug 22, 2022
Merged

[3.11] gh-96046: Initialize ht_cached_keys in PyType_Ready() (GH-96047) #96164

merged 1 commit into from
Aug 22, 2022
+30 −9

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 22, 2022 •
edited by bedevere-bot
Loading

@tiran @miss-islington
pythongh-96046: Initialize ht_cached_keys in PyType_Ready() (pythonGH…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9776890 
…-96047)

(cherry picked from commit 53e6a9a)

Co-authored-by: Christian Heimes <[email protected]>
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Aug 22, 2022
Merged
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 9776890 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 22, 2022
@tiran tiran requested a review from pablogsal August 22, 2022 05:24
@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

4 similar comments
@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

markshannon
markshannon approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3ea0beb into python:3.11 Aug 22, 2022
@miss-islington miss-islington deleted the backport-53e6a9a-3.11 branch August 22, 2022 09:13
rwgk added a commit to rwgk/pybind11_scons that referenced this pull request Aug 22, 2022
@rwgk
As used for retesting:
9168ad0 
pybind/pybind11#4142 (comment)

main: python/cpython#96047
3.11: python/cpython#96164
@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a pending ❌ .

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

1 similar comment
@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a failure ❌.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a failure ❌.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a failure ❌.

@miss-islington
Copy link
Contributor Author

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a failure ❌.

3 similar comments
@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a failure ❌.

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a failure ❌.

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a failure ❌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

@pablogsal pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miss-islington @bedevere-bot @markshannon @tiran