Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 684: Mark as Final #3810

Merged
merged 1 commit into from
Jun 4, 2024
Merged

PEP 684: Mark as Final #3810

merged 1 commit into from
Jun 4, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jun 2, 2024 •
edited by github-actions bot
Loading

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Also remove redundant Content-Type field.
I guess this PEP doesn't need a canonical-doc directive

📚 Documentation preview 📚: https://pep-previews--3810.org.readthedocs.build/

@Eclips4 Eclips4 requested a review from hugovk June 2, 2024 07:57
ericsnowcurrently
ericsnowcurrently approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hugovk
hugovk approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit e73affa into python:main Jun 4, 2024
7 checks passed
@Eclips4 Eclips4 deleted the pep_684_final branch June 4, 2024 17:21
@ncoghlan ncoghlan mentioned this pull request Jun 5, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eclips4 @ericsnowcurrently @hugovk