Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile nav obstructing content #96

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

philg314
Copy link
Contributor

@philg314 philg314 commented Aug 8, 2022

Instead of adding the height of .mobile-nav at the top of .document it is now added at the top of body.

Closes #95

@hugovk
Copy link
Member

hugovk commented Feb 13, 2023

(Rebased on main to retrigger the CI and create an RTD build preview: https://python-docs-theme-previews--96.org.readthedocs.build/en/96/)

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally with the banner enabled on the 3.8 branch:

diff --git a/Doc/tools/templates/layout.html b/Doc/tools/templates/layout.html
index 98ccf42248..0151a00593 100644
--- a/Doc/tools/templates/layout.html
+++ b/Doc/tools/templates/layout.html
@@ -1,13 +1,11 @@
 {% extends "!layout.html" %}
 
 {% block header %}
-{%- if outdated %}
 <div id="outdated-warning" style="padding: .5em; text-align: center; background-color: #FFBABA; color: #6A0E0E;">
     {% trans %}This document is for an old version of Python that is no longer supported.
     You should upgrade, and read the {% endtrans %}
     <a href="/3/{{ pagename }}{{ file_suffix }}">{% trans %} Python documentation for the current stable release{% endtrans %}</a>.
 </div>
-{%- endif %}
 {% endblock %}
 
 {% block rootrellink %}

Before

After

@pradyunsg pradyunsg merged commit 8e007f6 into python:main Feb 13, 2023
@pradyunsg
Copy link
Member

Thanks for the screenshots on this @hugovk! ^.^

@hugovk hugovk mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation with responsive theme (3.8+) will hide "not supported" banner behind navbar for mobile layouts
3 participants