Replace aliases by builtins.* in uuid
#10422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aliases were used because the class has properties called `int` and `bytes`. I think it is better to use the shadowed types from the builtins module. This should not change anything from the type checking side but it improves the IDE experience[^1]. [^1]: I was using uuid recently and the aliases showed up in vscode, I thought they were uuid special types and had to look in the stub to know what they are.
AlexWaygood
approved these changes
Jul 8, 2023
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Thanks Alex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aliases were used because the class has properties called
intandbytes. I think it is better to use the shadowed types from the builtins module. This should not change anything from the type checking side but it improves the IDE experience1.Footnotes
I was using uuid recently and the aliases showed up in vscode, I thought they were uuid special types and had to look in the stub to know what they are. ↩