Change types in "builtins" and "types" modules to have __new__ instead of __init__, where necessary #10761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
facebook-github-bot
pushed a commit
to facebook/pyre-check
that referenced
this pull request
Nov 28, 2023
Summary: - sqlite2.dbapi2.Connection.execute: https://github.com/python/typeshed/blob/main/stdlib/sqlite3/dbapi2.pyi#L355C1-L356C1 sqlite execute takes a `__sql`instead of `sql` - getattr https://github.com/python/typeshed/blob/main/stdlib/builtins.pyi#L1428 `name` param is now `__name` - filter python/typeshed#10761 modified builtins type to use `__new__` instead of `__init__` (https://github.com/python/typeshed/blob/main/stdlib/builtins.pyi#L1416) - enumerate: similar to point above https://github.com/python/typeshed/blob/main/stdlib/builtins.pyi#L1208C9-L1208C16 Reviewed By: arthaud Differential Revision: D51464336 fbshipit-source-id: eb4aa6e04707c1c1d4ab3b5b02f27fd4e044189f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that calls to eg
range.__new__(range, 0)will be checked correctly. The most common case for this is if a subclass of range makes its own__new__method, and callssuper().__new__(although some of the classes affected by this PR cannot be subclassed).I have deliberately ignored the reversed class, because it is the subject of its own ongoing PR, #10655.