Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ts_utils editable #12806

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Oct 14, 2024

No description provided.

@Avasam
Copy link
Collaborator

Avasam commented Oct 16, 2024

Might need an update of our requirements validation to special case this. But if it works as expected it would be great and basically remove the last disadvantage of this technique.

@Avasam
Copy link
Collaborator

Avasam commented Mar 7, 2025

I've been considering moving our dev dependencies to a pyproject.toml. And using builtin toml solutions to read/parse deps rather that our custom per-line read-and-validate solution.

Now that pip supports PEP 735: pypa/pip#13065, we could declare a proper dev dependency group.

Edit: I am realizing that there's no standard way to have a local file editable install in pyproject dependencies. Looks like a hole in the spec. uv does it like this:

[dependency-groups]
dev = [
    # Utilities for typeshed infrastructure scripts.
    "ts-utils",
]

[tool.uv.sources]
ts-utils = { path = "lib", editable = true }

Which would force us to tell contributors to pre-emptively install uv, rather than it being installed with pip install --group=dev :/
I love uv, but I appreciate that we still use it optionally as a drop-in replacement for pip.

Edit 2: I was getting somewhere, but this is also blocker in uv, unless we force using uv: astral-sh/uv#9258 (comment) & astral-sh/uv#9683 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants