Allow adding test cases testing version-dependent Python features #9238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently impossible to add a test case for
ExceptionGroup
orBaseExceptionGroup
: see #9230. You'd think that you'd be able to just put the test behind anif sys.version_info >= (3, 11)
guard, and pyright is indeed fine with that. Mypy, however, is not: when you run the test case with--python-version 3.10
, it complains about many "unused type ignore" comments (it detects thetype: ignore
comments behind theif sys.version_info >= (3, 11)
guard, even though it considers the whole block unreachable with--python-version 3.10
, meaning it considers alltype: ignore
s within that block to be "unused").This PR works around that mypy annoyance. If this PR is merged, the test-case file can simply be renamed to be
test_cases/stdlib/builtins/check_exception_group-py311.py
, andpython tests/regr_test.py --all
should pass.Cc. @sobolevn