adjust interface #3669
Closed
adjust interface #3669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: # Why 1. we're extracting the size wrong after the latest changes, rather than extracing it from w1 we need to get it from w2 as w1 is treated at 2x intermediate size on `gate_only=False` 2. we're hard-coding the weights dtype when we should be extracting it 3. we're using the default stream instead of the current stream # What 1. get intermediate size from w2 2. do not hard-code the `topk_weights` dtype 3. use current stream Reviewed By: sijiac Differential Revision: D69341443
|
This pull request was exported from Phabricator. Differential Revision: D69341443 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in 718ea47. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3669 Pull Request resolved: facebookresearch/FBGEMM#747 # Why 1. we're extracting the size wrong after the latest changes, rather than extracing it from w1 we need to get it from w2 as w1 is treated at 2x intermediate size on `gate_only=False` 2. we're hard-coding the weights dtype when we should be extracting it 3. we're using the default stream instead of the current stream # What 1. get intermediate size from w2 2. do not hard-code the `topk_weights` dtype 3. use current stream Reviewed By: sijiac Differential Revision: D69341443 fbshipit-source-id: cf7a908c6a78d3ecb9d030491722967fbe0d097b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Why
gate_only=FalseWhat
topk_weightsdtypeReviewed By: sijiac
Differential Revision: D69341443