Fix the TBE cache_precision to fp32 when on ROCm #3672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It was discovered that FP16 cache precision caused a 500x slowdown in performance of `split_embedding_nobag_backward_codegen_rowwise_adagrad_unweighted_kernel_warp_per_row_1` kernel on ROCm, so to work around this, we fix cache precision to be FP32 always for the ROCm environment case. Differential Revision: D69130978
|
No ciflow labels are configured for this repo. |
|
This pull request was exported from Phabricator. Differential Revision: D69130978 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in fc718cf. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3672 It was discovered that FP16 cache precision caused a 500x slowdown in performance of `split_embedding_nobag_backward_codegen_rowwise_adagrad_unweighted_kernel_warp_per_row_1` kernel on ROCm, so to work around this, we fix cache precision to be FP32 always for the ROCm environment case. Reviewed By: sryap Differential Revision: D69130978 fbshipit-source-id: ca904e54fc8446f5517fba5486d7497f49730fa4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It was discovered that FP16 cache precision caused a 500x slowdown in performance of
split_embedding_nobag_backward_codegen_rowwise_adagrad_unweighted_kernel_warp_per_row_1kernel on ROCm, so to work around this, we fix cache precision to be FP32 always for the ROCm environment case.Differential Revision: D69130978