[fbgemm_gpu] Add Scripts for Generating Release Reports #3676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
q10
commented
Feb 11, 2025
•
q10
commented
- Add scripts for generating release reports
❌ Deploy Preview for pytorch-fbgemm-docs failed.
|
q10
force-pushed
the
bm/scrape-commits
branch
4 times, most recently
from
0bae084 to
06e7f6b
Compare
q10
changed the title
|
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 7, 2025
Summary: - Add scripts for generating release reports Differential Revision: D72581171 Pulled By: q10
|
This pull request was exported from Phabricator. Differential Revision: D72581171 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 7, 2025
Summary: X-link: facebookresearch/FBGEMM#1022 - Add scripts for generating release reports Differential Revision: D72581171 Pulled By: q10
|
This pull request was exported from Phabricator. Differential Revision: D72581171 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 7, 2025
Summary: X-link: facebookresearch/FBGEMM#1022 - Add scripts for generating release reports Differential Revision: D72581171 Pulled By: q10
|
This pull request was exported from Phabricator. Differential Revision: D72581171 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 7, 2025
Summary: Add scripts for generating release reports. The previous interation of the scraper script was based on a flawed understanding of the GItHub PR API. Initially, I thought it was possible to grep the API for merged PRs in reverse sorted order, but it turns out that PR timestamps can be updated after merge, and PR information is based on open/close state of PR, not merge state. So it is much better to first fetch all parent commits for a given branch/tag/ref from a start timetamp, then for each commit, search the API for its associated PR, and then pull the PR information. Even though this invokes more API calls and is slower, it is more accurate. Additionally, the code has been rewritten to support more operations in the future. For example, in this diff is a new command that fetches unlabeled PRs, which is useful for us as we construct a release report. Differential Revision: D72581171 Pulled By: q10
|
This pull request was exported from Phabricator. Differential Revision: D72581171 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 8, 2025
Summary: Add scripts for generating release reports. The previous interation of the scraper script was based on a flawed understanding of the GItHub PR API. Initially, I thought it was possible to grep the API for merged PRs in reverse sorted order, but it turns out that PR timestamps can be updated after merge, and PR information is based on open/close state of PR, not merge state. So it is much better to first fetch all parent commits for a given branch/tag/ref from a start timetamp, then for each commit, search the API for its associated PR, and then pull the PR information. Even though this invokes more API calls and is slower, it is more accurate. Additionally, the code has been rewritten to support more operations in the future. For example, in this diff is a new command that fetches unlabeled PRs, which is useful for us as we construct a release report. Example releases report: P1778912161 Example report of unlabeled PRs: P1778913261 Test Plan: Imported from GitHub, without a `Test Plan:` line. Example: ``` python scrape.py release-report --ref v1.1.2-rc1 --since 2025-04-01 ``` Differential Revision: D72581171 Pulled By: q10
|
This pull request was exported from Phabricator. Differential Revision: D72581171 |
Summary: X-link: facebookresearch/FBGEMM#1022 Add scripts for generating release reports. The previous interation of the scraper script was based on a flawed understanding of the GItHub PR API. Initially, I thought it was possible to grep the API for merged PRs in reverse sorted order, but it turns out that PR timestamps can be updated after merge, and PR information is based on open/close state of PR, not merge state. So it is much better to first fetch all parent commits for a given branch/tag/ref from a start timetamp, then for each commit, search the API for its associated PR, and then pull the PR information. Even though this invokes more API calls and is slower, it is more accurate. Additionally, the code has been rewritten to support more operations in the future. For example, in this diff is a new command that fetches unlabeled PRs, which is useful for us as we construct a release report. Example releases report: P1778912161 Example report of unlabeled PRs: P1778913261 Test Plan: Imported from GitHub, without a `Test Plan:` line. Example: ``` python scrape.py release-report --ref v1.1.2-rc1 --since 2025-04-01 ``` Differential Revision: D72581171 Pulled By: q10
|
This pull request was exported from Phabricator. Differential Revision: D72581171 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: Pull Request resolved: facebookresearch/FBGEMM#1022 Add scripts for generating release reports. The previous interation of the scraper script was based on a flawed understanding of the GItHub PR API. Initially, I thought it was possible to grep the API for merged PRs in reverse sorted order, but it turns out that PR timestamps can be updated after merge, and PR information is based on open/close state of PR, not merge state. So it is much better to first fetch all parent commits for a given branch/tag/ref from a start timetamp, then for each commit, search the API for its associated PR, and then pull the PR information. Even though this invokes more API calls and is slower, it is more accurate. Additionally, the code has been rewritten to support more operations in the future. For example, in this diff is a new command that fetches unlabeled PRs, which is useful for us as we construct a release report. Example releases report: P1778912161 Example report of unlabeled PRs: P1778913261 X-link: pytorch#3676 Test Plan: Imported from GitHub, without a `Test Plan:` line. Example: ``` python scrape.py release-report --ref v1.1.2-rc1 --since 2025-04-01 ``` Reviewed By: spcyppt Differential Revision: D72581171 Pulled By: q10 fbshipit-source-id: 88e998a1dcc98078526dcb7e1b2d566b467080ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.