Set default value to null #3732
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#814 Context: We use block_bucketize_sparse_features_cpu kernel to bucketize kjt, for kjt with weights = none, the returned kjt has weights tensor to be `Tensor (undefined)` which cause it couldn't be serialized. This diff set the default value to std::nullopt and only initialize the weights when the orignal kjt has weights. Error message ``` terminate called after throwing an instance of 'c10::ValueError' what(): The tensor at position 1 cannot be serialized. Only tensors with allocated storage are supported. ``` Apply same logic to all other 3 fields Reviewed By: sryap Differential Revision: D70143698
|
This pull request was exported from Phabricator. Differential Revision: D70143698 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request has been merged in 7017af2. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
Summary: X-link: pytorch#3732 Pull Request resolved: facebookresearch/FBGEMM#814 Context: We use block_bucketize_sparse_features_cpu kernel to bucketize kjt, for kjt with weights = none, the returned kjt has weights tensor to be `Tensor (undefined)` which cause it couldn't be serialized. This diff set the default value to std::nullopt and only initialize the weights when the orignal kjt has weights. Error message ``` terminate called after throwing an instance of 'c10::ValueError' what(): The tensor at position 1 cannot be serialized. Only tensors with allocated storage are supported. ``` Apply same logic to all other 3 fields Reviewed By: sryap Differential Revision: D70143698 fbshipit-source-id: c12dd360be3f5a21c8d330e1666cd447e97c1b54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/814
Context:
We use block_bucketize_sparse_features_cpu kernel to bucketize kjt, for kjt with weights = none, the returned kjt has weights tensor to be
Tensor (undefined)which cause it couldn't be serialized. This diff set the default value to std::nullopt and only initialize the weights when the orignal kjt has weights.Error message
Apply same logic to all other 3 fields
Reviewed By: sryap
Differential Revision: D70143698