Skip to content

Report TBE data configuration with EEG-based indices estimation #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gchalump
Copy link
Contributor

Summary:

  • Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
  • Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450767

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 3a402a9
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/680bd9a7d60e2b000867ffd4
😎 Deploy Preview https://deploy-preview-4018--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 24, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106


- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 24, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106


- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450767

gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 24, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106

Pull Request resolved: pytorch#4018

- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450767

gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 24, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106

Pull Request resolved: pytorch#4018

- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
@gchalump gchalump force-pushed the export-D73450767 branch 2 times, most recently from 438db97 to 36c7ced Compare April 25, 2025 14:43
gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 25, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106


- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 25, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106


- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450767

gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 25, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106

Pull Request resolved: pytorch#4018

- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450767

gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 25, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106

Pull Request resolved: pytorch#4018

- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
q10 and others added 2 commits April 25, 2025 11:20
…h out D71147675, pt 2)

Summary:
- Add the option to report TBE data configuration with EEG-based indices
  estimation

Differential Revision: D71519199
…G-based indices estimation (flesh out D71147675, pt 2)

Differential Revision: D73397802
gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 25, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106


- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 25, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106


- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450767

gchalump added a commit to gchalump/FBGEMM that referenced this pull request Apr 25, 2025
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106

Pull Request resolved: pytorch#4018

- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
…rch#4018)

Summary:
X-link: facebookresearch/FBGEMM#1106

Pull Request resolved: pytorch#4018

- Separate a new method in the TBEBenchmarkParamsReporter class that extracts the TBE data configuration parameters from the SplitTableBatchedEmbeddingBagsCodegen object and returns them as TBEDataConfig.
- Add unit test to verify extracted TBEDataConfig.

Differential Revision: D73450767
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73450767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants