Clean up WeightRow in preparation for optimizer state offloading
#4021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
force-pushed
the
export-D73473546
branch
4 times, most recently
from
5afcdf0 to
bdf4726
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
q10
force-pushed
the
export-D73473546
branch
2 times, most recently
from
2e7ddaf to
174e1da
Compare
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
Summary: - Fix `int32_t` to `auto` for code around `WeightRow` - Fix `kINT8QparamsBytes` from `float` to `int32_t` Differential Revision: D73690651
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
Summary: - Simplify weight row cache load and evict routines Differential Revision: D73693209
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 26, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 26, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 26, 2025
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
…ytorch#4021) Summary: Pull Request resolved: pytorch#4021 X-link: facebookresearch/FBGEMM#1109 - Clean up `WeightRow` implementation in preparation for optimizer state offloading - Add documentation for the class Differential Revision: D73473546
|
This pull request was exported from Phabricator. Differential Revision: D73473546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
WeightRowimplementation in preparation for optimizer state offloadingDifferential Revision: D73473546