Skip to content

Enable NaN checks on tensor arguments to kernel launches #4029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Apr 26, 2025

Summary: - Enable NaN checks on tensor arguments to kernel launches

Differential Revision: D73698678

Summary:
- Migrate Jinja `make_pta_acc_format()` from the old `MAKE_PTA_WITH_NAME` and
  `MAKE_PTA_ACC_WITH_NAME` to  using `PTA_B` and `PTA_ACC_B`

- Fix a constexpr issue with `FBGEMM_LAUNCH_KERNEL` macro

Differential Revision: D73417820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73698678

Copy link

netlify bot commented Apr 26, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit a578c90
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/680d5228033a0100084be873
😎 Deploy Preview https://deploy-preview-4029--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 26, 2025
Summary:

- Enable NaN checks on tensor arguments to kernel launches

Differential Revision: D73698678
@q10 q10 force-pushed the export-D73698678 branch from cfa02a3 to 7365eb7 Compare April 26, 2025 21:28
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 26, 2025
Summary:

- Enable NaN checks on tensor arguments to kernel launches

Differential Revision: D73698678
@q10 q10 force-pushed the export-D73698678 branch from 7365eb7 to a822829 Compare April 26, 2025 21:28
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73698678

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 26, 2025
Summary:
Pull Request resolved: pytorch#4029

- Enable NaN checks on tensor arguments to kernel launches

Differential Revision: D73698678
@q10 q10 force-pushed the export-D73698678 branch from a822829 to 37753fa Compare April 26, 2025 21:30
Summary:
X-link: facebookresearch/FBGEMM#1113

Pull Request resolved: pytorch#4029

- Enable NaN checks on tensor arguments to kernel launches

Differential Revision: D73698678
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73698678

@q10 q10 force-pushed the export-D73698678 branch from 37753fa to a578c90 Compare April 26, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants