Move batched_complete_cumsum op to FBGEMM #4036
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebookresearch/FBGEMM#1121 X-link: facebookresearch/generative-recommenders#271 `asynchronous_batched_complete_cumsum` implements batched complete_cumsum in a single kernel to avoid writing for loop in python. Move the kernel from `generative_recommenders` folder to FBGEMM so that it can be used in different models. The kernel has not been used in production yet so the change is safe. Reviewed By: sryap, zhaozhul, q10 Differential Revision: D72906062
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D72906062 |
|
This pull request has been merged in 3cef662. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1121
X-link: facebookresearch/generative-recommenders#271
asynchronous_batched_complete_cumsumimplements batched complete_cumsum in a single kernel to avoid writing for loop in python.Move the kernel from
generative_recommendersfolder to FBGEMM so that it can be used in different models. The kernel has not been used in production yet so the change is safe.Reviewed By: sryap, zhaozhul, q10
Differential Revision: D72906062