Add outcome and feature names to datasets #2015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48926319 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 18, 2023
Summary: This will help us while passing data around in Ax by offering more granular information on what each dataset represents. Also hard-deprecates `dict_from_iter` method that was unused outside of tests. Differential Revision: D48926319
saitcakmak
force-pushed
the
export-D48926319
branch
from
3718fe6 to
9d95c4c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48926319 |
Codecov Report
@@ Coverage Diff @@
## main #2015 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 179 179
Lines 15807 15803 -4
=========================================
- Hits 15807 15803 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 18, 2023
Summary: Follows up pytorch/botorch#2015 to propagate the changes in Ax and fixes the tests. Differential Revision: D49340640 fbshipit-source-id: bce2bed5639b8f816c74fbc32ee3145d43b33a9e
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 18, 2023
Summary: This will help us while passing data around in Ax by offering more granular information on what each dataset represents. Also hard-deprecates `dict_from_iter` method that was unused outside of tests. Differential Revision: D48926319
saitcakmak
force-pushed
the
export-D48926319
branch
from
9d95c4c to
f23a8ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48926319 |
Summary: This will help us while passing data around in Ax by offering more granular information on what each dataset represents. Also hard-deprecates `dict_from_iter` method that was unused outside of tests. Reviewed By: Balandat Differential Revision: D48926319
saitcakmak
force-pushed
the
export-D48926319
branch
from
f23a8ab to
39940ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48926319 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 19, 2023
…k#1853) Summary: Pull Request resolved: facebook#1853 Follows up pytorch/botorch#2015 to propagate the changes in Ax and fixes the tests. Reviewed By: Balandat Differential Revision: D49340640 fbshipit-source-id: 81a51ce81d4d1977e88365f73065f9214ca3d48b
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Sep 19, 2023
Summary: Pull Request resolved: #1853 Follows up pytorch/botorch#2015 to propagate the changes in Ax and fixes the tests. Reviewed By: Balandat Differential Revision: D49340640 fbshipit-source-id: c775aaafaf35c84d8d342d1fcfae55f59e974f20
|
This pull request has been merged in aa13c14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will help us while passing data around in Ax by offering more granular information on what each dataset represents.
Also hard-deprecates
dict_from_itermethod that was unused outside of tests.Differential Revision: D48926319