Detach tensor in gen_candidates_scipy to avoid test failure due to new warning
#2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new warning Summary: pytorch/pytorch#143261 added a new warning to pytorch that gets raised when converting a tensor with gradients to a scalar without detaching it first. This caused some test failues in botorch (which are likely a bit overzealous, but we can fix that separately). This makes a change in `gen_candidates_scipy` to fix this. There are most likely other occurrences of this in botorch that we should fix, but here I'm quickly addressing the test failures first. Reviewed By: saitcakmak Differential Revision: D72286925
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72286925 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 207 207
Lines 18695 18695
=======================================
Hits 18692 18692
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Resolved by da6ee3a (unclear why this wasn't auto-closed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
pytorch/pytorch#143261 added a new warning to pytorch that gets raised when converting a tensor with gradients to a scalar without detaching it first.
This caused some test failues in botorch (which are likely a bit overzealous, but we can fix that separately). This makes a change in
gen_candidates_scipyto fix this.There are most likely other occurrences of this in botorch that we should fix, but here I'm quickly addressing the test failures first.
Reviewed By: saitcakmak
Differential Revision: D72286925