Move arm.passes to arm._passes #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tarun292 wants to merge 1 commit into main from export-D63926055

Contributor

tarun292 commented Oct 6, 2024

Differential Revision: D63926055

pytorch-bot bot commented Oct 6, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5918

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit a694fa0 with merge base 57e3c81 ():

CANCELLED JOB - The following job was cancelled. Please retry:

trunk / test-models-macos (cmake, resnet50, xnnpack-quantization-delegation, macos-m1-stable, 90) / macos-job (gh)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Oct 6, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

facebook-github-bot added the fb-exported label

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

afeee8e

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 16d592c to afeee8e Compare

October 7, 2024 15:14

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

1 similar comment

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from afeee8e to 0358382 Compare

October 7, 2024 15:21

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

927994b

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 0358382 to 927994b Compare

October 7, 2024 15:27

helunwencser approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

61fd243

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 927994b to 61fd243 Compare

October 7, 2024 20:06

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

b25f3d2

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 61fd243 to b25f3d2 Compare

October 7, 2024 20:14

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

c7183b5

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from b25f3d2 to c7183b5 Compare

October 7, 2024 20:21

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

1 similar comment

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

3e274c8

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from c7183b5 to 3e274c8 Compare

October 7, 2024 20:27

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

e0efc13

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 3e274c8 to e0efc13 Compare

October 7, 2024 23:17

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from e7cc45d to f999be8 Compare

October 10, 2024 01:12

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

65b6f5a

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from f999be8 to 65b6f5a Compare

October 10, 2024 01:18

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

c641daa

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 65b6f5a to c641daa Compare

October 10, 2024 01:26

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

e03eb7b

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from c641daa to e03eb7b Compare

October 10, 2024 01:32

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

483effd

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from e03eb7b to 483effd Compare

October 10, 2024 05:08

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

2f538f5

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 483effd to 2f538f5 Compare

October 10, 2024 05:15


          Move arm.passes to arm._passes (#5918)

a694fa0

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request was exported from Phabricator. Differential Revision: D63926055

tarun292 force-pushed the export-D63926055 branch from 2f538f5 to a694fa0 Compare

October 10, 2024 05:22

facebook-github-bot closed this in

83c95df

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Oct 10, 2024

This pull request has been merged in 83c95df.

Contributor Author

tarun292 commented Oct 10, 2024

@pytorchbot cherry-pick --onto release/0.4 -c critical

Collaborator

pytorchbot commented Oct 10, 2024

Cherry picking #5918

Command git -C /home/runner/work/executorch/executorch cherry-pick -x -X theirs 83c95dffbb84a1bbf0933ec3cefdecfa0244b98b returned non-zero exit code 1

Auto-merging backends/arm/_passes/arm_pass_manager.py
CONFLICT (rename/delete): backends/arm/passes/arm_pass_utils.py renamed to backends/arm/_passes/arm_pass_utils.py in 83c95dffb (Move arm.passes to arm._passes (#5918)), but deleted in HEAD.
CONFLICT (rename/delete): backends/arm/passes/cast_int64_pass.py renamed to backends/arm/_passes/cast_int64_pass.py in 83c95dffb (Move arm.passes to arm._passes (#5918)), but deleted in HEAD.
Auto-merging backends/arm/_passes/convert_split_to_slice.py
CONFLICT (rename/delete): backends/arm/passes/decompose_div_pass.py renamed to backends/arm/_passes/decompose_div_pass.py in 83c95dffb (Move arm.passes to arm._passes (#5918)), but deleted in HEAD.
CONFLICT (rename/delete): backends/arm/passes/scalars_to_attribute_pass.py renamed to backends/arm/_passes/scalars_to_attribute_pass.py in 83c95dffb (Move arm.passes to arm._passes (#5918)), but deleted in HEAD.
Auto-merging backends/arm/arm_backend.py
Auto-merging backends/arm/arm_partitioner.py
Auto-merging backends/arm/quantizer/arm_quantizer.py
error: could not apply 83c95dffb... Move arm.passes to arm._passes (#5918)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

tarun292 mentioned this pull request

Move arm.passes to arm._passes (#5918) #6112

Closed

tarun292 added a commit to tarun292/executorch-2 that referenced this pull request


          Move arm.passes to arm._passes (pytorch#5918)

14b594f

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: pytorch#5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

fbshipit-source-id: 141a5be9f3a81e75784825357bacbab91904620c
(cherry picked from commit 83c95df)

tarun292 mentioned this pull request

Move arm.passes to arm._passes (#5918) #6128

Merged

tarun292 added a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918)

dc8708b

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

fbshipit-source-id: 141a5be9f3a81e75784825357bacbab91904620c
(cherry picked from commit 83c95df)

jackzhxng pushed a commit that referenced this pull request


          Move arm.passes to arm._passes (#5918) (#6128)

485a486

Summary:
Changing arm.passes to arm._passes to indicate that these passes are not covered under the API stability guarantee.

Pull Request resolved: #5918

Reviewed By: malfet, helunwencser

Differential Revision: D63926055

fbshipit-source-id: 141a5be9f3a81e75784825357bacbab91904620c
(cherry picked from commit 83c95df)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed fb-exported Merged partner: arm