Skip to content

remove old configs leftover from removal of py3.5/py2 #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2021
Merged

remove old configs leftover from removal of py3.5/py2 #1551

merged 2 commits into from
Jan 11, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jan 10, 2021 •
edited
Loading

Description: remove old configs leftover from removal of py3.5/py2

  • removed .travis.yaml
  • Changed/remove leftover python3.5
  • removed comments that's no longer true
  • regular import of skimage after py3.5 removal
  • remove python version from requirement-dev.txt
  • universal no longer needed since ignite only supports >= py3.6

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 10, 2021

universal no longer needed since ignite only supports >= py3.6

Could you please give a reference about why we can omit universal for >= py3.6 ?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jan 10, 2021

universal no longer needed since ignite only supports >= py3.6

Could you please give a reference about why we can omit universal for >= py3.6 ?

https://packaging.python.org/guides/distributing-packages-using-setuptools/#universal-wheels

vfdev-5
vfdev-5 approved these changes Jan 11, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff

@vfdev-5 vfdev-5 merged commit 9e4a44a into pytorch:master Jan 11, 2021
@ydcjeff ydcjeff deleted the rm-old-config branch January 11, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydcjeff @vfdev-5