[ch] optimize master_commit_red_percent query #6580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf:
Removes expensive join, improves the pre-filtering utilizing a materialized view.
Testing
The new query in some cases returns slightly different results for
broken_trunk_red
metrics (although results forall_red
metric are identical), which leads me to conclude that partitioning:is not stable (missing workflow_name? each row can have multiple pushes?)
but overall the results are close enough (ε < 0.01) and further debugging and fixing could be made in a separate PR.