Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify torchdata version extraction in packaging script #2129

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Mar 28, 2023

Simplify torchdata version extraction in packaging script
test:

conda list -fe torchdata 
# This file may be used to create an environment using:
# $ conda create --name <env> --file <this file>
# platform: linux-64
torchdata=0.7.0.dev20230328=py310

conda list -fe torchdata | grep torchdata | sed -e 's/torchdata=\(.*\)=py.*/\1/'
0.7.0.dev202303283

@atalman atalman changed the title Simplify torchdata versionextraction in packaging script Simplify torchdata version extraction in packaging script Mar 28, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:build. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

@atalman atalman merged commit 10d1349 into pytorch:main Mar 28, 2023
@osalpekar
Copy link
Member

osalpekar commented Mar 28, 2023

@atalman Looks like Linux Conda release jobs start failing from this PR. Nightlies were fine until 03/27 and started failing on 03/28: https://github.com/pytorch/text/actions/workflows/build-conda-linux.yml?query=event%3Apush+branch%3Anightly. We might need to revert/refactor this to get nightlies green again (looks like we are affecting the version compatibility based on the build error).

cc @joecummings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants