Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop RoCM Support for Text Linux Wheels #2212

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Drop RoCM Support for Text Linux Wheels #2212

merged 1 commit into from
Oct 16, 2023

Conversation

osalpekar
Copy link
Member

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2212

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 5 Unrelated Failures

As of commit 94388dc with merge base 6eba7c0 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will want a second opinion as well from @kartikayk

@seemethere seemethere requested a review from kartikayk October 16, 2023 20:35
@abhinavarora abhinavarora self-requested a review October 16, 2023 20:50
Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think this change will resolve the version mismatch issue as seen in installation of torchmultimodal? Also, could you list down any potential side-effects of this change?

@seemethere seemethere merged commit c0d0685 into main Oct 16, 2023
@seemethere seemethere deleted the drop-rocm branch October 16, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants