Skip to content

[Not for landing] piggy back on titan for scale init test #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: gh/fduwjj/1/base
Choose a base branch
from
Draft

[Not for landing] piggy back on titan for scale init test #841

wants to merge 9 commits into from

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Feb 13, 2025 •
edited
Loading

fduwjj added a commit that referenced this pull request Feb 13, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
de4388d 
ghstack-source-id: 8e8b5d5
Pull Request resolved: #841
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 13, 2025
@fduwjj fduwjj marked this pull request as draft February 13, 2025 05:58
fduwjj added a commit that referenced this pull request Feb 13, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
f0bf91c 
ghstack-source-id: 8852e63
Pull Request resolved: #841
fduwjj added a commit that referenced this pull request Feb 13, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
88b77de 
ghstack-source-id: 1199eaf
Pull Request resolved: #841
fduwjj added a commit that referenced this pull request Feb 13, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
75278ce 
ghstack-source-id: a009c10
Pull Request resolved: #841
fduwjj added a commit that referenced this pull request Feb 14, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
910b707 
ghstack-source-id: 6b41f54
Pull Request resolved: #841
@kwen2501
Copy link
Contributor

Can you run an all-reduce on delta to get the avg/min/max init time across ranks?
It will reduce the script processing post benchmarking.

@fduwjj
Copy link
Contributor Author

fduwjj commented Feb 14, 2025

We are doing post-processing anyway. so I don't think all-reduce is needed. Plus by the time, there is no PG already.

fduwjj added a commit that referenced this pull request Mar 3, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
f9d2b2c 
ghstack-source-id: c6a5b0d
Pull Request resolved: #841
fduwjj added a commit that referenced this pull request Mar 3, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
7762399 
ghstack-source-id: f11a19b
Pull Request resolved: #841
fduwjj added a commit that referenced this pull request Mar 3, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
a068c6f 
ghstack-source-id: 1a2c666
Pull Request resolved: #841
fduwjj added a commit that referenced this pull request Mar 3, 2025
@fduwjj
[Not for landing] piggy back on titan for scale init test
7e48c46 
ghstack-source-id: 0b551fe
Pull Request resolved: #841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fduwjj @kwen2501 @facebook-github-bot