Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm use_cuda param #3002

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix: rm use_cuda param #3002

merged 3 commits into from
Aug 19, 2024

Conversation

shaoyuyoung
Copy link
Contributor

@shaoyuyoung shaoyuyoung commented Aug 17, 2024

this PR removes the use_cuda param as it originally shows below:
https://pytorch.org/tutorials/recipes/recipes/profiler_recipe.html#pytorch-profiler
image

Actually, the param use_cuda is deprecated
image
If this param is still in tutorials, it would mislead someone.

cc @aaronenyeshi @chaekit @subramen

Copy link

pytorch-bot bot commented Aug 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3002

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4de93ab with merge base 6a7b26c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @shaoyuyoung!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svekars svekars merged commit 42aaa33 into pytorch:main Aug 19, 2024
17 checks passed
svekars added a commit that referenced this pull request Aug 23, 2024
Co-authored-by: Svetlana Karslioglu <[email protected]>
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
Co-authored-by: Svetlana Karslioglu <[email protected]>
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
Co-authored-by: Svetlana Karslioglu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants