Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro_onnx.py #3033

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Update intro_onnx.py #3033

merged 1 commit into from
Sep 5, 2024

Conversation

labintsev
Copy link
Contributor

@labintsev labintsev commented Sep 4, 2024

Add onnxruntime dependency

Fixes #3027

Description

The ONNX exporter depends on extra Python packages: onnx, onnxscript and onnxruntime. I think we need explicit list of dependencies in text and in code.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @xadupre @thiagocrepaldi

Add onnxruntime dependency
Copy link

pytorch-bot bot commented Sep 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3033

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 191691a with merge base 5c45426 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @labintsev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@svekars svekars added the onnx Issues relating to ONNX label Sep 4, 2024
@svekars
Copy link
Contributor

svekars commented Sep 4, 2024

Can you please sign the CLA @labintsev

@labintsev
Copy link
Contributor Author

done

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@svekars svekars merged commit a0b5d4b into pytorch:main Sep 5, 2024
19 checks passed
@labintsev labintsev deleted the patch-1 branch September 6, 2024 07:49
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
Add onnxruntime dependency
c-p-i-o pushed a commit that referenced this pull request Sep 6, 2024
Add onnxruntime dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed onnx Issues relating to ONNX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - miissed onnxruntime dependency
5 participants